Skip to content

Restored the document file and modified the scrolling implementation …#1399

Merged
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
martinwq997:main
Sep 2, 2025
Merged

Restored the document file and modified the scrolling implementation …#1399
benjamin-747 merged 2 commits into
gitmono-dev:mainfrom
martinwq997:main

Conversation

@martinwq997

Copy link
Copy Markdown
Contributor

…of the Rust pages.

@vercel

vercel Bot commented Sep 1, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mega Ready Ready Preview Comment Sep 1, 2025 1:38pm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the document file and modifies the scrolling implementation for Rust pages. The changes implement a fixed layout system with proper scrolling containers instead of relying on window-level scrolling.

  • Updated global HTML/body styles to use fixed positioning and overflow control
  • Converted Rust pages from min-height layouts to fixed height flex containers with dedicated scroll areas
  • Modified scroll-to-top functionality to target specific scroll containers rather than the window

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
moon/apps/web/pages/_document.tsx Sets global fixed layout with overflow hidden on HTML and body elements
moon/apps/web/pages/[org]/rust/rust-news/index.tsx Converts to flex layout with fixed header and scrollable content area
moon/apps/web/pages/[org]/rust/rust-ecosystem/search/index.tsx Implements fixed header sections with scrollable results area
moon/apps/web/pages/[org]/rust/rust-ecosystem/index.tsx Updates main ecosystem page to use fixed height with overflow auto
moon/apps/web/pages/[org]/rust/rust-ecosystem/crate-info/[crateName]/layout.tsx Creates fixed layout structure for crate info pages
moon/apps/web/pages/[org]/rust/rust-ecosystem/crate-info/[crateName]/index.tsx Adds bottom padding to scrollable content

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread moon/apps/web/pages/[org]/rust/rust-news/index.tsx
Comment thread moon/apps/web/pages/[org]/rust/rust-ecosystem/search/index.tsx
Comment thread moon/apps/web/pages/[org]/rust/rust-ecosystem/search/index.tsx
Comment thread moon/apps/web/pages/[org]/rust/rust-ecosystem/index.tsx
@benjamin-747
benjamin-747 added this pull request to the merge queue Sep 2, 2025
Merged via the queue into gitmono-dev:main with commit 220373d Sep 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants